fix: handle non node: prefixed Node.js builtins when no npm specifiers were found #5785
+100
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
force-pushed
the
fix/handle-non-prefixed-node-builtin-without-npm-specifiers
branch
from
22ace7f to
9779bf1
Compare
eduardoboucas
approved these changes
Jul 29, 2024
pieh
force-pushed
the
fix/handle-non-prefixed-node-builtin-without-npm-specifiers
branch
from
ae98286 to
49fa267
Compare
|
This pull request adds or modifies JavaScript ( |
pieh
force-pushed
the
fix/handle-non-prefixed-node-builtin-without-npm-specifiers
branch
from
49fa267 to
9b85230
Compare
pieh
deleted the
fix/handle-non-prefixed-node-builtin-without-npm-specifiers
branch
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
We are creating
x->node:ximport map entries to support node builtins in Deno, but we only do that when we found at least one "npm" specifier. This is looking to always create node builtins entries regardless of npm specifiers state.Suggest reviewing with "hide whitespace" mode ( https://github.com/netlify/build/pull/5785/files?w=1 ) as the fix largely just replace early bail with moving some a bit of code under condition instead which just changed indentation on a lot of lines
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)