Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: combine functions from Frameworks API and internal directories #5734

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

eduardoboucas
Copy link
Member

Summary

This is a follow-up to #5668. When bundling functions and edge functions, I was choosing either the frameworks API directory or the previous internal directory. I realised we need to keep using both, because integrations will not migrate to the frameworks API and we need to keep building the functions they generate.

Verified

This commit was signed with the committer’s verified signature.
Byron Sebastian Thiel
@eduardoboucas eduardoboucas requested review from a team as code owners June 24, 2024 10:19
Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

Verified

This commit was signed with the committer’s verified signature.
Byron Sebastian Thiel
Copy link
Contributor

@lukasholzer lukasholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eduardoboucas eduardoboucas merged commit 9a087b1 into main Jun 24, 2024
37 checks passed
@eduardoboucas eduardoboucas deleted the feat/frameworks-api-and-internal branch June 24, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants