feat: pass output flusher to callChild
#5677
Merged
+146
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoboucas
changed the title
callChild
|
This pull request adds or modifies JavaScript ( |
Skn0tt
approved these changes
May 28, 2024
|
|
||
| return { | ||
| outputFlusher, | ||
| stdout: new OutputFlusherTransform(outputFlusher).pipe(stdout), |
There was a problem hiding this comment.
smart idea to define them here, so unpipe works 👍
This was referenced Jun 5, 2024
Merged
Merged
Merged
Merged
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #5643 with a couple of small changes:
b4f9a10: passes the output flusher to the
callChildmethod, and ensures that we callunpipeon the streams that have been wrapped with the transform6586800: refactored the
streamto use TypeScript.