Skip to content

fix: fix deployment of framework-info icons #4917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 6, 2023

Conversation

lukasholzer
Copy link
Contributor

@lukasholzer lukasholzer commented Mar 6, 2023

🎉 Thanks for submitting a pull request! 🎉

Summary

We don't need the toml as the root is on / so this toml is never used.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

Sorry, something went wrong.

@lukasholzer lukasholzer requested a review from danez March 6, 2023 09:51
@netlify
Copy link

netlify bot commented Mar 6, 2023

Deploy Preview for framework-info ready!

Name Link
🔨 Latest commit 2f3a053
🔍 Latest deploy log https://app.netlify.com/sites/framework-info/deploys/6405c07917452f0008532f0e
😎 Deploy Preview https://deploy-preview-4917--framework-info.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

danez
danez previously approved these changes Mar 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@lukasholzer lukasholzer changed the title chore: use newer node version fix: fix deployment of framework-info icons Mar 6, 2023
@kodiakhq kodiakhq bot merged commit 5803c1a into main Mar 6, 2023
@kodiakhq kodiakhq bot deleted the chore/use-newer-node-version branch March 6, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants