Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(framework-info): detect gatsby typescript project #4895

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

SevenOutman
Copy link
Contributor

@SevenOutman SevenOutman commented Feb 28, 2023

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes #4894

Add gatsby-config.ts to configFiles registry for Gatsby.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

Sorry, something went wrong.

@SevenOutman
Copy link
Contributor Author

SevenOutman commented Feb 28, 2023

Hi @lukasholzer, sorry to disturb but the CircleCI check seems to be failing again for some configuration reasons.

lukasholzer
lukasholzer previously approved these changes Feb 28, 2023
Copy link
Contributor

@lukasholzer lukasholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM – will check out why the pipeline could not run 🤔

@lukasholzer
Copy link
Contributor

That's weird it cannot find the config file, but we've enabled building for forks.

CleanShot 2023-02-28 at 11 00 00

@lukasholzer
Copy link
Contributor

lukasholzer commented Feb 28, 2023

can you follow the error message and re authenticate and then force update the commit and trigger a rebuild?

@SevenOutman
Copy link
Contributor Author

can you follow the error message and re authenticate and then force update the commit and trigger a rebuild?

Sure. I've re-authed CircleCI and the checks seems to be running now. Bit confused why it works like this 🤔

@kodiakhq kodiakhq bot merged commit 3978402 into netlify:main Mar 1, 2023
@SevenOutman SevenOutman deleted the fix/framework-info-gatsby-ts branch March 2, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[framework-info] Not detecting Gatsby if it's in TypeScript
2 participants