Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle non-writable error.name #4227

Merged
merged 2 commits into from
Mar 14, 2022
Merged

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Mar 14, 2022

Fixes #4226

This handles error.name when it is not writable.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code πŸ§‘β€πŸ’». This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire πŸ”₯ (e.g. incident related), you can skip this step.
  • Read the contribution guidelines πŸ“–. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) πŸ§ͺ
  • Update or add documentation (if features were changed or added) πŸ“
  • Make sure the status checks below are successful βœ…

Sorry, something went wrong.

@ehmicky ehmicky added the type: bug code to address defects in shipped code label Mar 14, 2022
@ehmicky ehmicky self-assigned this Mar 14, 2022
@kodiakhq kodiakhq bot merged commit 2128d21 into main Mar 14, 2022
@kodiakhq kodiakhq bot deleted the fix/error-name-non-writable branch March 14, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error reporting crashes when the name property is not writable
2 participants