Skip to content

fix: truncate long headers and redirects in build logs #4172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 21, 2022

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Feb 21, 2022

Fixes #4163

When printing headers/redirects in the build logs, those should be truncated when they are too long.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
bagder Daniel Stenberg
@ehmicky ehmicky added the type: bug code to address defects in shipped code label Feb 21, 2022
@ehmicky ehmicky self-assigned this Feb 21, 2022

Verified

This commit was signed with the committer’s verified signature.
bagder Daniel Stenberg
@ehmicky ehmicky merged commit 216213f into main Feb 21, 2022
@ehmicky ehmicky deleted the fix/truncate-array-logs branch February 21, 2022 17:02
ehmicky added a commit that referenced this pull request Feb 21, 2022

Verified

This commit was signed with the committer’s verified signature.
bagder Daniel Stenberg
This reverts commit 216213f.
kodiakhq bot pushed a commit that referenced this pull request Feb 21, 2022

Verified

This commit was signed with the committer’s verified signature.
bagder Daniel Stenberg
…" (#4176)

* Revert "fix: truncate long headers and redirects in build logs (#4172)"

This reverts commit 216213f.

* fix: pin `netlify-redirect-parser` version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing builds should truncate large config logs
2 participants