Skip to content

Commit a57f853

Browse files
authoredJul 1, 2024··
Merge pull request #2952 from voriteam/clintonb/name-bug
fix: Retain $ref when setting name property
2 parents d0a58e0 + 94f565c commit a57f853

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed
 

Diff for: ‎lib/services/schema-object-factory.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -365,7 +365,7 @@ export class SchemaObjectFactory {
365365
if (metadata.isArray) {
366366
return this.transformToArraySchemaProperty(metadata, key, { $ref });
367367
}
368-
const keysToRemove = ['type', 'isArray', 'required'];
368+
const keysToRemove = ['type', 'isArray', 'required', 'name'];
369369
const validMetadataObject = omit(metadata, keysToRemove);
370370
const extraMetadataKeys = Object.keys(validMetadataObject);
371371

Diff for: ‎test/services/fixtures/create-profile.dto.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@ export class CreateProfileDto {
1010
lastname: string;
1111

1212
@ApiProperty({
13-
type: () => CreateUserDto
13+
type: () => CreateUserDto,
14+
name: 'parent'
1415
})
1516
parent: CreateUserDto;
1617
}

0 commit comments

Comments
 (0)
Please sign in to comment.