test(@nestjs/config) reset env correctly #1665
Merged
+12
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
I made a similar test file in config repo simply.
In this case we expect
run test 2
to be failed. We guess the process.env will be reset in afterEach.but it succeed.
Because
envBackup
variable is reference ofprocess.env
. If you change eitherenvBackup
orprocess.env
, both of them will be updated. It doesn't be reset.The first test case affects second test case. in second test case
process.env.a
is not undefined.What is the new behavior?
Fortunately test cases in config repo have developed independently. All test cases pass.
But I wanna remove a potential risk.
I changed they don't refer each other.
And I hope to add more test cases after merging. : )
Does this PR introduce a breaking change?
Other information