Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(light-client): let the function that builds filter data to be standalone #3890

Conversation

yangby-cryptape
Copy link
Collaborator

What problem does this PR solve?

The code that builds filter data could not be reuse.

What is changed and how it works?

Move those code to be a standalone function.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Release note

Title Only: Include only the PR title in the release note.

Verified

This commit was signed with the committer’s verified signature.
yangby-cryptape Boyu Yang
…e standalone
@yangby-cryptape yangby-cryptape requested a review from a team as a code owner March 15, 2023 20:01
@yangby-cryptape yangby-cryptape requested review from zhangsoledad and quake and removed request for a team March 15, 2023 20:01
@quake quake added this pull request to the merge queue Mar 16, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 16, 2023
@zhangsoledad zhangsoledad added this pull request to the merge queue Mar 16, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 16, 2023
@zhangsoledad zhangsoledad added this pull request to the merge queue Mar 20, 2023
@zhangsoledad zhangsoledad merged commit 24bd21a into nervosnetwork:develop Mar 20, 2023
@doitian doitian mentioned this pull request Apr 13, 2023
3 tasks
@yangby-cryptape yangby-cryptape deleted the pr/light-client/move-block-filter-builder-to-types branch June 7, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants