Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for dlist #4

Closed
prudhomm opened this issue Oct 17, 2022 · 4 comments
Closed

add support for dlist #4

prudhomm opened this issue Oct 17, 2022 · 4 comments

Comments

@prudhomm
Copy link
Contributor

dlist do not seem supported.

toto::
  titi
titi::
  toto

I get messages like

asciidoctor: WARNING: Unsupported node: dlist, ignoring.
asciidoctor: WARNING: Unsupported node: dlist, ignoring.
asciidoctor: WARNING: Unsupported node: dlist, ignoring.
asciidoctor: WARNING: Unsupported node: dlist, ignoring.
@prudhomm
Copy link
Contributor Author

since they are not supported by markdown, can we consider them as ulist and work with that ?

@prudhomm
Copy link
Contributor Author

@ggrossetie we can certainly generate easily the markdown for a definition list, however I am not sure how to get the definition title and the definition body

@ggrossetie
Copy link
Contributor

since they are not supported by markdown, can we consider them as ulist and work with that ?

I think we can take some inspiration from https://github.com/opendevise/downdoc which converts AsciiDoc to Markdown but I like your idea.

we can certainly generate easily the markdown for a definition list, however I am not sure how to get the definition title and the definition body

Usually, I take a look at how Asciidoctor (Ruby) converts an node to HTML: https://github.com/asciidoctor/asciidoctor/blob/cbd991a398cb10f28ce5c69c6ef0c6881c79fe39/lib/asciidoctor/converter/html5.rb#L516C25-L596

The interesting part: https://github.com/asciidoctor/asciidoctor/blob/cbd991a398cb10f28ce5c69c6ef0c6881c79fe39/lib/asciidoctor/converter/html5.rb#LL579-L591C24

@ggrossetie
Copy link
Contributor

AsciiDoc

CPU:: The brain of the computer.
Hard drive:: Permanent storage for operating system and/or user files.
RAM:: Temporarily stores information the CPU uses during operation.
Keyboard:: Used to enter text or control items on the screen.
Mouse:: Used to point to and select items on your computer screen.
Monitor:: Displays information in visual form using text and graphics.

Markdown

* **CPU**\
The brain of the computer.
* **Hard drive**\
Permanent storage for operating system and/or user files.
* **RAM**\
Temporarily stores information the CPU uses during operation.
* **Keyboard**\
Used to enter text or control items on the screen.
* **Mouse**\
Used to point to and select items on your computer screen.
* **Monitor**\
Displays information in visual form using text and graphics.
  • CPU
    The brain of the computer.
  • Hard drive
    Permanent storage for operating system and/or user files.
  • RAM
    Temporarily stores information the CPU uses during operation.
  • Keyboard
    Used to enter text or control items on the screen.
  • Mouse
    Used to point to and select items on your computer screen.
  • Monitor
    Displays information in visual form using text and graphics.

ggrossetie added a commit that referenced this issue Jun 1, 2023
Also reduce verbosity when a node is unsupported.

resolves #14
ggrossetie added a commit that referenced this issue Jun 1, 2023
Also reduce verbosity when a node is unsupported.

resolves #14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants