Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coverage report --include wildcard matching is broken since 7.0.0 #1571

Closed
kkaarreell opened this issue Mar 3, 2023 · 1 comment
Closed

coverage report --include wildcard matching is broken since 7.0.0 #1571

kkaarreell opened this issue Mar 3, 2023 · 1 comment
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@kkaarreell
Copy link

Describe the bug
Wildcard matching doesn't work properly for coverage report --include since v7.0.0
Coverage data are present in db, just the report is not generated properly when wildcards are used.

To Reproduce
How can we reproduce the problem? Please be specific. Don't link to a failing CI job. Answer the questions below:

  1. What version of Python are you using?
    python3-3.11.2-1.fc37
  2. What version of coverage.py shows the problem? The output of coverage debug sys is helpful.
    starting v7.0.0
  3. What versions of what packages do you have installed? The output of pip freeze is helpful.
alembic==1.7.7
argcomplete==2.0.0
attrs==22.1.0
Babel==2.10.3
Beaker==1.10.0
cffi==1.15.1
charset-normalizer==2.1.0
cloud-init==22.2
configobj==5.0.6
coverage==7.0.0
cryptography==37.0.2
dbus-python==1.2.18
decorator==5.1.1
distro==1.7.0
gpg==1.17.0
greenlet==1.1.2
gssapi==1.7.3
idna==3.3
Jinja2==3.0.3
jsonpatch==1.21
jsonpointer==2.0
jsonschema==4.10.0
keylime==6.5.2
koji==1.32.0
lark-parser==0.9.0
libcomps==0.1.18
lxml==4.9.1
Mako==1.1.4
MarkupSafe==2.1.1
netifaces==0.11.0
oauthlib==3.2.1
packaging==21.3
Paste==3.5.0
ply==3.11
prettytable==0.7.2
progressbar2==3.53.2
psutil==5.9.1
pyasn1==0.4.8
pyasn1-modules==0.2.8
pycparser==2.20
pycrypto==2.6.1
pygit2==1.7.1
pyOpenSSL==21.0.0
pyparsing==3.0.9
pyrsistent==0.18.1
pyserial==3.5
PySocks==1.7.1
python-dateutil==2.8.2
python-gnupg==0.5.0
python-utils==3.1.0
pytz==2022.7.1
PyYAML==6.0
pyzmq==23.2.0
requests==2.28.1
requests-gssapi==1.2.3
rpm==4.18.0
rpmautospec==0.3.5
selinux==3.4
sepolicy==3.4
setools==4.4.0
six==1.16.0
SQLAlchemy==1.4.46
Tempita==0.5.2
tornado==6.2
urllib3==1.26.12
  1. What code shows the problem? Give us a specific commit of a specific repo that we can check out. If you've already worked around the problem, please provide a commit before that fix.

That would be a bit more difficult I am afraid but if necessary I can prepare one for you.

  1. What commands did you run?
    See console log below
# pip show coverage
Name: coverage
Version: 6.5.0
Summary: Code coverage measurement for Python
Home-page: https://github.com/nedbat/coveragepy
Author: Ned Batchelder and 161 others
Author-email: ned@nedbatchelder.com
License: Apache 2.0
Location: /usr/local/lib64/python3.11/site-packages
Requires: 
Required-by: 
# coverage report --include '*keylime*' | grep -c keylime
111
# pip uninstall coverage
Found existing installation: coverage 6.5.0
Uninstalling coverage-6.5.0:
  Would remove:
    /usr/local/bin/coverage
    /usr/local/bin/coverage-3.11
    /usr/local/bin/coverage3
    /usr/local/lib64/python3.11/site-packages/coverage-6.5.0.dist-info/*
    /usr/local/lib64/python3.11/site-packages/coverage/*
Proceed (Y/n)? y
  Successfully uninstalled coverage-6.5.0
WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
# pip3 install coverage==7.0.0
Collecting coverage==7.0.0
  Downloading coverage-7.0.0-cp311-cp311-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl (219 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 219.8/219.8 kB 3.3 MB/s eta 0:00:00
Installing collected packages: coverage
Successfully installed coverage-7.0.0
WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
# coverage report --include '*keylime*' 
Name                                                                                          Stmts   Miss  Cover
-----------------------------------------------------------------------------------------------------------------
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/db/keylime_db.py        65     11    83%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/keylime_agent.py       520    335    36%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/keylime_logging.py      33     11    67%
-----------------------------------------------------------------------------------------------------------------
TOTAL                                                                                           618    357    42%
# coverage report
Name                                                                                                                                                  Stmts   Miss  Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/__init__.py                                                                      0      0   100%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/agentstates.py                                                                 151     83    45%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/api_version.py                                                                  73     33    55%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/backport_dataclasses.py                                                        355    355     0%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/ca_impl_openssl.py                                                              73     51    30%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/ca_util.py                                                                     361    303    16%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/cert_utils.py                                                                   87     65    25%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/cli/__init__.py                                                                  0      0   100%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/cli/options.py                                                                  34     16    53%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/cli/policies.py                                                                 72     53    26%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/cloud_verifier_common.py                                                       143    120    16%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/cloud_verifier_tornado.py                                                      875    728    17%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/cmd/__init__.py                                                                  0      0   100%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/cmd/agent.py                                                                     9      4    56%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/cmd/ca.py                                                                        9      9     0%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/cmd/convert_ima_policy.py                                                      139    139     0%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/cmd/ima_emulator_adapter.py                                                     72     13    82%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/cmd/registrar.py                                                                12      4    67%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/cmd/tenant.py                                                                   14      5    64%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/cmd/user_data_encrypt.py                                                        40     31    22%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/cmd/verifier.py                                                                 12      4    67%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/cmd_exec.py                                                                     45      8    82%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/common/__init__.py                                                               0      0   100%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/common/algorithms.py                                                            47      2    96%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/common/exception.py                                                              9      3    67%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/common/migrations.py                                                            11      0   100%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/common/retry.py                                                                  9      6    33%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/common/states.py                                                                30      1    97%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/common/validators.py                                                            42     25    40%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/config.py                                                                      150     43    71%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/crypto.py                                                                      115     61    47%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/da/__init__.py                                                                   0      0   100%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/da/examples/__init__.py                                                          0      0   100%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/da/examples/file.py                                                             57     57     0%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/da/examples/redis.py                                                            63     63     0%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/da/examples/rekor.py                                                            11     11     0%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/da/examples/sqldb.py                                                            73     73     0%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/da/examples/tsa_rfc3161.py                                                      24     24     0%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/da/record.py                                                                   195    160    18%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/db/__init__.py                                                                   0      0   100%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/db/keylime_db.py                                                                65     11    83%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/db/registrar_db.py                                                              21      0   100%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/db/verifier_db.py                                                               55      0   100%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/elchecking/__init__.py                                                           1      0   100%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/elchecking/__main__.py                                                          26     26     0%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/elchecking/example.py                                                          114     92    19%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/elchecking/policies.py                                                          50     18    64%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/elchecking/tests.py                                                            422    307    27%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/failure.py                                                                     127     56    56%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/fs_util.py                                                                       5      1    80%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/ima/__init__.py                                                                  0      0   100%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/ima/ast.py                                                                     226    100    56%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/ima/dm_grammar.py                                                                1      0   100%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/ima/file_signatures.py                                                         287    190    34%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/ima/ima.py                                                                     363    312    14%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/ima/ima_dm.py                                                                  587    257    56%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/ima/ima_test.py                                                                 28     28     0%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/json.py                                                                         47     15    68%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/keylime_agent.py                                                               520    335    36%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/keylime_logging.py                                                              33     11    67%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/measured_boot.py                                                                64     49    23%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/migrations/__init__.py                                                           0      0   100%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/migrations/env.py                                                               60     21    65%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/migrations/versions/1ac1513ef2a1_fix_mb_and_ima_column_types.py                 22      5    77%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/migrations/versions/2fbc0fb8fa4d_add_checksum_to_allowlist.py                   18      3    83%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/migrations/versions/7d5db1a6ffb0_add_agentstates_columns.py                     25      6    76%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/migrations/versions/8a44a4364f5a_initial_database_migration.py                  21      3    86%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/migrations/versions/8da20383f6e1_extend_ip_field.py                             19      3    84%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/migrations/versions/63c30820fdc1_add_mtls_cert_and_ak_to_verifier_db.py         20      4    80%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/migrations/versions/257fe0f0c039_add_fields_for_revocation_context_to_.py       20      4    80%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/migrations/versions/4089e1c79be9_add_tpm_clockinfo.py                           19      3    84%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/migrations/versions/4329e2d14944_associate_moved_allowlists_to_agents.py        26      5    81%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/migrations/versions/9169f80345ed_add_supported_version_to_verifiermain_.py      20      3    85%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/migrations/versions/039322ea079b_add_generator_column.py                        18      3    83%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/migrations/versions/__init__.py                                                  0      0   100%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/migrations/versions/a7a64155ab3a_add_ima_filesigning_keys_column.py             18      3    83%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/migrations/versions/a09cc94177f0_add_last_received_quote.py                     18      3    83%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/migrations/versions/a72aec03d720_migrate_allowlists_to_separate_table.py        39     14    64%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/migrations/versions/a79c27ec1054_add_mtls_cert_field_to_registrar.py            18      3    83%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/migrations/versions/ae898986c6e9_add_mb_refstate_column.py                      18      3    83%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/migrations/versions/b4d024197413_add_verfier_id_to_verifiermain_table.py        22      5    77%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/migrations/versions/bc3b6b551b0a_drop_vtpm_colums.py                            23      4    83%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/migrations/versions/bf48e0c4751d_add_attestation_count_column.py                18      3    83%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/migrations/versions/c3842cc9ee69_store_keyrings_learned_from_ima_log.py         19      3    84%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/migrations/versions/cc2630851a1f_receive_the_aik_tpm_from_the_agent.py          28      8    71%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/migrations/versions/eb869a77abd1_create_allowlist_table.py                      18      3    83%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/migrations/versions/eeb702f77d7d_allowlist_rename.py                            20      4    80%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/migrations/versions/f35cdd35eb83_move_v_tpm_policy_to_jsonpickletype.py         23      5    78%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/migrations/versions/f82c4252bc4f_add_ip_and_port_to_registrar.py                22      5    77%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/registrar_client.py                                                            113     58    49%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/registrar_common.py                                                            349    165    53%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/requests_client.py                                                              50     15    70%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/revocation_actions/__init__.py                                                   0      0   100%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/revocation_actions/print_metadata.py                                             5      5     0%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/revocation_actions/update_crl.py                                                42     42     0%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/revocation_notifier.py                                                         159    133    16%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/secure_mount.py                                                                 65     31    52%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/signing.py                                                                      51     41    20%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/tenant.py                                                                      819    594    27%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/tornado_requests.py                                                             40     34    15%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/tpm/__init__.py                                                                  0      0   100%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/tpm/tpm2_objects.py                                                            199     98    51%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/tpm/tpm2_objects_test.py                                                        85     85     0%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/tpm/tpm_abstract.py                                                            245    131    47%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/tpm/tpm_main.py                                                                942    513    46%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/tpm_bootlog_enrich.py                                                          134    134     0%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/tpm_ek_ca.py                                                                    22     14    36%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/types.py                                                                         6      2    67%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/user_utils.py                                                                   65     22    66%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/user_utils_test.py                                                              34     34     0%
/usr/local/lib/python3.11/site-packages/keylime-6.5.2-py3.11.egg/keylime/web_util.py                                                                    250     87    65%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                                                                 10721   6728    37%

Expected behavior
wildcard matchin works properly (as for v6.5.0)
@kkaarreell kkaarreell added bug Something isn't working needs triage labels Mar 3, 2023
@kkaarreell kkaarreell mentioned this issue Mar 3, 2023
Merged
@marcgibbons marcgibbons mentioned this issue Apr 24, 2023
Closed
@nedbat
Copy link
Owner

nedbat commented Apr 27, 2023

Dup of #1604.

@nedbat nedbat closed this as not planned Won't fix, can't repro, duplicate, stale Apr 27, 2023
@nedbat nedbat added duplicate This issue or pull request already exists and removed needs triage labels Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nedbat @kkaarreell