Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up configuration time by recycling rootProject's git info #194

Merged
merged 3 commits into from
Feb 15, 2025

Conversation

wisechengyi
Copy link

@wisechengyi wisechengyi commented Feb 15, 2025

Problem

com.netflix.nebula.maven-scm will record some of the git info for publishing. It does the git info calculation at every project, which makes configuration time longer than necessary because the git info is not going to change for any project in the repo, especially in this case, we only want origin.

Solution

Reuse rootProjects' git info.

Effect

For repo with 175 projects, we see about 7s reduction for whole repo configuration.

Yi Cheng added 2 commits February 14, 2025 16:36

Verified

This commit was signed with the committer’s verified signature. The key has expired.
vbgl Vincent Laporte
@wisechengyi wisechengyi changed the title Cachegit Speed up git ops Feb 15, 2025
@wisechengyi wisechengyi changed the title Speed up git ops Speed up configuration time by recycling rootProject's git info Feb 15, 2025
@wisechengyi wisechengyi marked this pull request as ready for review February 15, 2025 01:23
@rpalcolea rpalcolea merged commit 32ab5a3 into nebula-plugins:main Feb 15, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants