Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Darkside] Padding sync #3651

Merged
merged 9 commits into from
Mar 12, 2025
Merged

[Darkside] Padding sync #3651

merged 9 commits into from
Mar 12, 2025

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Mar 11, 2025

Description

These changes should now sync Figma and code for darkside when it comes to padding changes.

  • Components now more consistently use space-20 for medium and space-16 for small

Component Checklist 📝

  • JSDoc
  • Examples
  • Documentation / Decision Records
  • Storybook
  • Style mappings (@navikt/core/css/config/_mappings.js)
  • Component tokens (@navikt/core/css/tokens.json)
  • CSS class deprecations (@navikt/aksel-stylelint/src/deprecations.ts)
  • Exports (@navikt/core/react/src/index.ts and @navikt/core/react/package.json)
  • New component? CSS import (@navikt/core/css/index.css)
  • Breaking change? Update migration guide. Consider codemod.
  • Changeset (Format: <Component>: <gitmoji?> <Text>. E.g. "Button: ✨ Add feature xyz.")

Sorry, something went wrong.

Copy link

changeset-bot bot commented Mar 11, 2025

🦋 Changeset detected

Latest commit: b382c63

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@KenAJoh KenAJoh requested a review from Copilot March 11, 2025 22:29

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR synchronizes the padding values in the darkside components with the Figma design guidelines.

  • Updated changeset to reflect the migration to consistent padding values
  • Ensures the proper patch update for "@navikt/ds-css" to support the changes
Copy link
Contributor

Storybook demo / Chromatic

40281b8b8 | 91 components | 135 stories

@KenAJoh KenAJoh requested a review from Copilot March 12, 2025 08:15

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request synchronizes the padding settings between Figma and the code for the Darkside project.

  • Updated changeset to reflect the patch change for padding synchronization
  • Introduced a changeset file that specifies the patch release for @navikt/ds-css
@KenAJoh KenAJoh merged commit 56971a1 into main Mar 12, 2025
6 checks passed
@KenAJoh KenAJoh deleted the darkside-padding-sync-3 branch March 12, 2025 09:29
@github-actions github-actions bot mentioned this pull request Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants