-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Darkside] Padding sync #3651
[Darkside] Padding sync #3651
Conversation
🦋 Changeset detectedLatest commit: b382c63 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR synchronizes the padding values in the darkside components with the Figma design guidelines.
- Updated changeset to reflect the migration to consistent padding values
- Ensures the proper patch update for "@navikt/ds-css" to support the changes
Storybook demo / Chromatic40281b8b8 | 91 components | 135 stories |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request synchronizes the padding settings between Figma and the code for the Darkside project.
- Updated changeset to reflect the patch change for padding synchronization
- Introduced a changeset file that specifies the patch release for @navikt/ds-css
Description
These changes should now sync Figma and code for darkside when it comes to padding changes.
Component Checklist 📝
@navikt/core/css/config/_mappings.js
)@navikt/core/css/tokens.json
)@navikt/aksel-stylelint/src/deprecations.ts
)@navikt/core/react/src/index.ts
and@navikt/core/react/package.json
)@navikt/core/css/index.css
)<Component>: <gitmoji?> <Text>.
E.g. "Button: ✨ Add feature xyz.")