Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified Ordered Consumer #936

Merged
merged 7 commits into from
Jul 14, 2023
Merged

Simplified Ordered Consumer #936

merged 7 commits into from
Jul 14, 2023

Conversation

scottf
Copy link
Contributor

@scottf scottf commented Jun 30, 2023

  • The changes to the interface to support ordered are found in the StreamContext class.
  • ConsumerInfo getCachedConsumerInfo() was added to the MessageConsumer interface, the base interface of all endless consumes. You could already do ConsumerInfo getConsumerInfo()
  • ConsumerInfo is original (pre-simplification) in all places returned by simplification api
  • OrderedConsumerConfig was added to use when getting an ordered consumer to simplify. Only allows setting fields allowed for an ordered consumer.

@scottf scottf requested a review from piotrpio July 4, 2023 10:39
Copy link
Contributor

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@scottf scottf merged commit f8222ff into main Jul 14, 2023
2 checks passed
@scottf scottf deleted the ordered-pull branch July 14, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants