Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplification Tuning and Review #927

Merged
merged 3 commits into from
Jun 20, 2023
Merged

Simplification Tuning and Review #927

merged 3 commits into from
Jun 20, 2023

Conversation

scottf
Copy link
Contributor

@scottf scottf commented Jun 20, 2023

No description provided.

@@ -204,7 +204,6 @@ public String toString() {
ConsumerConfiguration cc;
long messageAlarmTime = -1;
boolean ordered;
boolean raiseStatusWarnings = true;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused

@scottf scottf requested a review from piotrpio June 20, 2023 00:43
Copy link
Contributor

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM save for one nit

src/main/java/io/nats/client/FetchConsumer.java Outdated Show resolved Hide resolved
@scottf scottf merged commit ae69edb into main Jun 20, 2023
2 checks passed
@scottf scottf deleted the simplification-review-n1 branch June 20, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants