Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Object Store Mirrors #1578

Merged
merged 1 commit into from Mar 4, 2024
Merged

Fix Object Store Mirrors #1578

merged 1 commit into from Mar 4, 2024

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Mar 4, 2024

When mirroring Object Store, there is a need to setup subject transformations. However, client also needs to bind to the stream to avoid stream lookup, which is both not necessary and expensive, and also does not work with Object Store mirrors.

Signed-off-by: Tomasz Pietrek tomasz@nats.io

When mirroring Object Store, there is a need to setup subject
transformations. However, client also needs to bind to the stream
to avoid stream lookup, which is both not necessary and expensive,
and also does not work with Object Store mirrors.

Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jarema Jarema merged commit 52a2d33 into main Mar 4, 2024
1 of 2 checks passed
@piotrpio piotrpio deleted the support-object-store-mirrors branch March 18, 2024 13:28
@piotrpio piotrpio mentioned this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants