Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add testing section and format contributing file #1574

Merged
merged 4 commits into from Feb 28, 2024
Merged

chore: add testing section and format contributing file #1574

merged 4 commits into from Feb 28, 2024

Conversation

yordis
Copy link
Contributor

@yordis yordis commented Feb 28, 2024

No description provided.

@yordis yordis marked this pull request as ready for review February 28, 2024 18:16
wallyqs
wallyqs reviewed Feb 28, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
wallyqs
wallyqs reviewed Feb 28, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
wallyqs
wallyqs reviewed Feb 28, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
wallyqs
wallyqs approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Yordis

@wallyqs wallyqs merged commit a04478f into nats-io:main Feb 28, 2024
1 check passed
@yordis yordis deleted the chore-improve-contributing-guide branch February 28, 2024 18:40
@piotrpio piotrpio mentioned this pull request Mar 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyqs wallyqs wallyqs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yordis @wallyqs