chore: Bind Object Store bucket stream when getting object. #1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryabramov-f3
force-pushed
the
dabramov-bind-stream-when-getting-obj
branch
3 times, most recently
from
0648187
to
c88ede9
Compare
dmitryabramov-f3
force-pushed
the
dabramov-bind-stream-when-getting-obj
branch
from
c88ede9
to
8dd5559
Compare
piotrpio
approved these changes
Feb 26, 2024
test/object_test.go
Outdated
| Name: fmt.Sprintf("OBJ_%s", mirrorBucketName), | ||
| Mirror: &nats.StreamSource{ | ||
| Name: fmt.Sprintf("OBJ_%s", bucketName), | ||
| //FilterSubject: fmt.Sprintf("$O.%s.>", bucketName), |
There was a problem hiding this comment.
Thanks! Addressed https://github.com/nats-io/nats.go/compare/8dd55597a3e322af2f638690cd860c5dfb0b7b7a..dce3c368c223901e66420afa21850e87f5782594 and tests pass this time.
The change is needed to properly operate on mirrored object store buckets. By binding stream nats.go does not need to search for stream by subjects (which does not work for mirrors).
dmitryabramov-f3
force-pushed
the
dabramov-bind-stream-when-getting-obj
branch
from
8dd5559
to
dce3c36
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change is needed to properly operate on mirrored object store buckets. By binding stream nats.go does not need to search for stream by subjects (which does not work for mirrors).
Related issue: nats-io/nats-server#5106