Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVED] Export nested ConsumerManager interface #1543

Merged
merged 1 commit into from Feb 14, 2024

Conversation

piotrpio
Copy link
Collaborator

@piotrpio piotrpio commented Feb 2, 2024

This exports streamConsumerManager which was used inside Stream interface.

This is done so that the interface methods are visible in godoc. Prior to this change, because streamConsumerManager is not exported, those methods are available in API but hidden from documentation.

Signed-off-by: Piotr Piotrowski piotr@synadia.com

@piotrpio piotrpio requested a review from Jarema February 2, 2024 14:48
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
@piotrpio piotrpio merged commit 373f09c into main Feb 14, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants