Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: safe to use with proper config #1529

Merged
merged 1 commit into from Jan 23, 2024
Merged

Conversation

thorntonmc
Copy link
Contributor

In the examples for establishing secure (TLS) connections to NATS - the README shows using a nats.Secure method - which allows us to pass in a TLS config.

However, the godoc warns against this. @wallyqs informed me that this comment can be removed.

Copy link
Collaborator

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution.

@piotrpio piotrpio merged commit f42d2be into nats-io:main Jan 23, 2024
1 check failed
@piotrpio piotrpio mentioned this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants