Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVED] CPU spike during recalc of first msg in memstore. #5629

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

derekcollison
Copy link
Member

@derekcollison derekcollison commented Jul 8, 2024

When recalculating for the first, make sure not to trip accidentally with a negative npc, and make sure to floor against first sequence as needed.

Resolves: #5621

Signed-off-by: Derek Collison derek@nats.io

Verified

This commit was signed with the committer’s verified signature.
derekcollison Derek Collison
…th a negative npc, and make sure to floor against first sequence as needed.

Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison derekcollison requested a review from a team as a code owner July 8, 2024 21:26
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 045833c into main Jul 8, 2024
3 checks passed
@derekcollison derekcollison deleted the recalc-first-msg branch July 8, 2024 21:57
wallyqs added a commit that referenced this pull request Jul 9, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Includes:

- #5610
- #5618
- #5616
- #5627
- #5629
- #5630
- #5632
- #5635
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

server deadlocks on /jsz access
2 participants