Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVED] Hold the lock for a msg block while calling sync. #5301

Merged
merged 1 commit into from
Apr 11, 2024
Merged

[IMPROVED] Hold the lock for a msg block while calling sync. #5301

merged 1 commit into from
Apr 11, 2024

Conversation

derekcollison
Copy link
Member

We detected issues with sync on certain storage subsystems. So will hold lock for msg block while calling sync.

Signed-off-by: Derek Collison derek@nats.io

@derekcollison
Hold the lock for a msg block while calling sync.
e8e350d 
Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison derekcollison requested a review from a team as a code owner April 11, 2024 11:41
neilalexander
neilalexander approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 953bb1c into main Apr 11, 2024
4 checks passed
@derekcollison derekcollison deleted the lock-sync branch April 11, 2024 12:03
@neilalexander neilalexander mentioned this pull request Apr 11, 2024
Merged
neilalexander added a commit that referenced this pull request Apr 11, 2024
@neilalexander
Cherry-pick PRs for v2.10.14-RC.6 (#5302)
69b8c81 
Cherry-picks the following into the v2.10.14 release branch:

* #5300
* #5301

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilalexander neilalexander neilalexander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@derekcollison @neilalexander