Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVED] Filestore logging on exceptional conditions. #5298

Merged
merged 2 commits into from
Apr 10, 2024
Merged

[IMPROVED] Filestore logging on exceptional conditions. #5298

merged 2 commits into from
Apr 10, 2024

Conversation

derekcollison
Copy link
Member

Also make sure when trying to match the first msg we do not skip on exceptional errors, even though we do not expect these.

Signed-off-by: Derek Collison derek@nats.io

@derekcollison
Added in logging for exceptional conditions in filestore. Also added …
4b86d2f 
…protection not to skip over msgs on some errors.

Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison
Fixed spelling and lint warnings.
dcee9f4 
Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison derekcollison requested a review from a team as a code owner April 10, 2024 21:27
wallyqs
wallyqs approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 0872e51 into main Apr 10, 2024
4 checks passed
@derekcollison derekcollison deleted the fs-log branch April 10, 2024 22:07
@wallyqs wallyqs mentioned this pull request Apr 10, 2024
Merged
wallyqs added a commit that referenced this pull request Apr 10, 2024
@wallyqs
Cherry picks for release v2.10.14 (#5299)
273a8d5 
Includes:
- #5298

Also the following PR was already included in the release/v2.10.14
branch this
[commit](6c59372):
- #5295
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyqs wallyqs wallyqs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@derekcollison @wallyqs