Fix checking max deliver when backoff is used #5242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code was just checking if max_deliver is >= than backoff, however infinite max_deliver is represented by -1, so it was erroring. This fixes that behavior. Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
kozlovic
added a commit
to nats-io/nats.c
that referenced
this pull request
Mar 26, 2024
With PR nats-io/nats-server#5242 in server code, not providing a MaxDeliver is considered unlimited and should not error out. So fixing test to set MaxDeliver <= to the backoff list to get the expected error. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
levb
pushed a commit
to nats-io/nats.c
that referenced
this pull request
Mar 27, 2024
* [FIXED] Build: issue on Android with NATS_EXTRA_LIB A user (@psantiagol) reported an issue (in #64) building on Android due to the use of `NATS_EXTRA_LIB`. This PR skip the definition of this variable if building on Android. Should other users then report that this is breaking their build on Android, we will have to make this a conditional based on a boolean build option. Signed-off-by: Ivan Kozlovic <ivan@synadia.com> * Fix test JetStreamBackOffRedeliveries With PR nats-io/nats-server#5242 in server code, not providing a MaxDeliver is considered unlimited and should not error out. So fixing test to set MaxDeliver <= to the backoff list to get the expected error. Signed-off-by: Ivan Kozlovic <ivan@synadia.com> --------- Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
levb
pushed a commit
to nats-io/nats.c
that referenced
this pull request
Apr 12, 2024
* [FIXED] Build: issue on Android with NATS_EXTRA_LIB A user (@psantiagol) reported an issue (in #64) building on Android due to the use of `NATS_EXTRA_LIB`. This PR skip the definition of this variable if building on Android. Should other users then report that this is breaking their build on Android, we will have to make this a conditional based on a boolean build option. Signed-off-by: Ivan Kozlovic <ivan@synadia.com> * Fix test JetStreamBackOffRedeliveries With PR nats-io/nats-server#5242 in server code, not providing a MaxDeliver is considered unlimited and should not error out. So fixing test to set MaxDeliver <= to the backoff list to get the expected error. Signed-off-by: Ivan Kozlovic <ivan@synadia.com> --------- Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was just checking if max_deliver is >= than backoff, however infinite max_deliver is represented by -1, so it was erroring. This fixes that behavior.
Signed-off-by: Tomasz Pietrek tomasz@nats.io