Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] Protect against corrupt msgBlock first or last sequence when doing indexing #5238

Merged
merged 1 commit into from
Mar 22, 2024
Merged

[FIXED] Protect against corrupt msgBlock first or last sequence when doing indexing #5238

merged 1 commit into from
Mar 22, 2024

Conversation

derekcollison
Copy link
Member

Resolves: #5236

Although unclear how the sequences got corrupted in the first place.

Signed-off-by: Derek Collison derek@nats.io

@derekcollison
Protect against corrupt msgBlock first or last sequence when doing in…
6811a3a 
…dexCacheBuf.

Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison derekcollison requested a review from a team as a code owner March 22, 2024 17:46
wallyqs
wallyqs approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 96645b4 into main Mar 22, 2024
4 checks passed
@derekcollison derekcollison deleted the issue-5236 branch March 22, 2024 18:10
@neilalexander neilalexander mentioned this pull request Apr 4, 2024
Merged
derekcollison added a commit that referenced this pull request Apr 4, 2024
@derekcollison
Cherry-pick PRs for v2.10.14-RC.2 (#5278)
8cafe5b 
Cherry-pick the following PRs into the v2.10.14 release branch:

* #5237
* #5238
* #5242
* #5208
* #5244
* #5248
* #5246
* #5112
* #5247
* #5256
* #5258
* #5264
* #5266
* #5267
* #5265
* #5271
* #5270
* #5272
* #5276
* #5274
* #5275
* #5277
* #5279

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyqs wallyqs wallyqs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JetStream: panic: runtime error: makeslice: cap out of range
2 participants
@derekcollison @wallyqs