[IMPROVED] Waiting queue for pull consumers #5233
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved waiting queue for pull requests to linked-list. We had issues with very large MaxWaiting configured and causing memory and GC issues, especially if compaction kicked in.
Also when new requests for msgs are received and we are full, only check waiting queue at most once per second to avoid CPU pressure when application is continually sending new requests when the queue is full.
Signed-off-by: Derek Collison derek@nats.io