[CHANGED] MQTT RMS consumer: instead of deleting/creating, create a u… #5017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nique one with an InactiveThreshold
kozlovic
reviewed
Jan 31, 2024
|
I am concerned by what I saw for a customer that might be triggered by quick succession of delete and add with same name but different NRG assignment. |
|
@derekcollison I can't get past the build error after several retries, |
|
I have seen this test starting to flap on Travis. I can have a look say tomorrow, but for now, if it is a blocker, add a |
derekcollison
approved these changes
Jan 31, 2024
| // The old one should expire and get deleted due to inactivity. The name for | ||
| // the durable is $MQTT_rmsgs_{uuid}_{server-name}, the server name is just | ||
| // for readability. | ||
| rmDurName := mqttRetainedMsgsStreamName + "_" + nuid.Next() + "_" + s.String() |
There was a problem hiding this comment.
Not really durable, just the name, and we only really expect it to live for the lifetime of the running server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time MQTT was initialized for an account on a server, it was re-creating the server-specific RMS consumer by deleting it and creating again, with the same name. @derek though it might be causing issues and suggested this change.
Now, always create a new consumer with a unique name, and a 5 minute inactivity threshold. Kept the code to delete the "legacy"-named consumer, even though it'd get executed at most once, errors ignored.