Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] authcallout - cleared client jwt options as onboarding the client would reparse the token (which was the bearer token to connect to the callout for limits such as subs/data/payload #5013

Merged
merged 1 commit into from Jan 30, 2024
Merged

[FIX] authcallout - cleared client jwt options as onboarding the client would reparse the token (which was the bearer token to connect to the callout for limits such as subs/data/payload #5013

merged 1 commit into from Jan 30, 2024

Conversation

aricart
Copy link
Member

@aricart aricart commented Jan 29, 2024 •
edited

FIX #5002

@aricart
Copy link
Member Author

aricart commented Jan 30, 2024

@derekcollison this seems to be the right fix

I left the debugging output so that we can have a final look, will strip that before we do PR

derekcollison
derekcollison reviewed Jan 30, 2024
View reviewed changes
server/auth_callout.go Outdated Show resolved Hide resolved
server/auth_callout.go Outdated Show resolved Hide resolved
server/auth_callout.go Outdated Show resolved Hide resolved
@aricart aricart changed the title [WIP] authcallout investigation [FIX] authcallout - cleared client jwt options as onboarding the client would reparse the token (which was the bearer token to connect to the callout for limits such as subs/data/payload Jan 30, 2024
@aricart aricart marked this pull request as ready for review January 30, 2024 14:57
@aricart aricart requested a review from a team as a code owner January 30, 2024 14:57
derekcollison
derekcollison approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks!

@aricart
[FIX] [authcallout] cleared the JWT option in on the client to preven…
16a8ba7 
…t a reparse of the permissions assigned to the callout connection regarding subs/payload/data.
@derekcollison
Copy link
Member

Need to fix spelling error and linter issue.

@derekcollison derekcollison merged commit 3bb4807 into main Jan 30, 2024
4 checks passed
@derekcollison derekcollison deleted the ac-subs branch January 30, 2024 16:45
@wallyqs wallyqs mentioned this pull request Jan 31, 2024
Merged
wallyqs added a commit that referenced this pull request Feb 1, 2024
@wallyqs
Cherry-pick PRs into v2.10.10 release branch (#5020)
2f8be20 
Includes:

- #5013 
- #5017 
- #5019 
- #5022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

External authorization (AuthCallout) not working with Scoped accounts
2 participants
@aricart @derekcollison