[FIXED] Memory growth on interest stream reset with high sequence numbers. #5011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…have very high ack floors, we could explode the pre-ack state. The pre-ack state should be minimal, and in this case, when the stream's last sequence is below the ackfloor, we should not process pre-acks during startup. Also fixed a bug that was not properly doing snapshots when the quick check state was a purged state. Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an interest stream has been reset with consumers that have very high ack floors, we could explode the pre-ack state.
The pre-ack state should be minimal, and in this case, when the stream's last sequence is below the ackfloor, we should not process pre-acks during startup.
Also fixed a bug that was not properly doing snapshots when the quick check state was a purged state.
Signed-off-by: Derek Collison derek@nats.io