[FIXED] Acking a redelivered msg with more pending outstanding that should move the ack floor. #5008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…liveries caused the ack floor calculations to not properly work when a gap was filled by an ack of a redelivered msg. The ack floor would move and fix itself when the pending went to zero. This fixes the bug introduced and goes back to the pending sequence always being the original consumer delivery sequence. Signed-off-by: Derek Collison <derek@nats.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A prior fix to deal with larger consumer delivery numbers due to redeliveries caused the ack floor calculations to not properly work when a gap was filled by an ack of a redelivered msg.
The ack floor would move and fix itself when the pending went to zero. This fixes the bug introduced and goes back to the pending sequence always being the original consumer delivery sequence.
Signed-off-by: Derek Collison derek@nats.io