Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for recovery to complete before sending snapshot on stream scale-up from R1 #5001

Merged
merged 1 commit into from Jan 26, 2024

Conversation

neilalexander
Copy link
Member

This PR ensures that we don't try to generate and send a snapshot to catch up followers on a stream scale-up from an R1 until recovery has completed.

Signed-off-by: Neil Twigg neil@nats.io

…-up from R1

Signed-off-by: Neil Twigg <neil@nats.io>
@neilalexander neilalexander requested a review from a team as a code owner January 25, 2024 15:54
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 98b4e22 into main Jan 26, 2024
4 checks passed
@derekcollison derekcollison deleted the neil/streamscaleup branch January 26, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants