Fix tracking holes in the message block index when they are at the end of the block #4988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekcollison
requested changes
Jan 23, 2024
…d of the block Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
force-pushed
the
neil/indexcachebuf
branch
from
2169d64
to
46fcc3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code only appeared to identify holes in the message block index if they appeared at the start of the block or in between non-deleted messages, but didn't detect afterwards if there was a drift between the last indexed sequence and the last seq from the state. This now fills those gaps in the index at the end of the block too.
This fixes the accounting problem that could cause
cacheAlreadyLoadedto incorrectly report that a block wasn't available in the cache when it actually was.Signed-off-by: Neil Twigg neil@nats.io