[IMPROVED] Do not load blocks when calling LoadNextMsg for the first time after restart or long inactivity #4969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll be at the beginning of the stream. We would walk all blocks, which if fss was loaded we could skip fairly quickly. However on a restart this could cause memory blocks to be loaded in just to be skipped. Signed-off-by: Derek Collison <derek@nats.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If LoadNextMsg was called with start sequence == FirstSeq, we would walk all blocks, which if fss was loaded we could skip fairly quickly. However on a restart or no activity past a sync interval this could cause memory blocks to be loaded in just to be skipped.
#4906
Signed-off-by: Derek Collison derek@nats.io