[FIXED] setStartingSequenceForSources could panic in some specific scenarios #4950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekcollison
requested changes
Jan 11, 2024
jnmoyne
force-pushed
the
jnm/fix-find-starting-seq-for-sources
branch
from
00d3689
to
30dee96
Compare
jnmoyne
force-pushed
the
jnm/fix-find-starting-seq-for-sources
branch
from
6eb6cab
to
f6e41cb
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
derekcollison
requested changes
Jan 11, 2024
Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
jnmoyne
force-pushed
the
jnm/fix-find-starting-seq-for-sources
branch
from
46f6ab1
to
ed8d997
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed setStartingSequenceForSources line using the wrong variable name