Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVED] Allow no_auth_user to be an nkey. #4938

Merged
merged 1 commit into from Jan 10, 2024
Merged

[IMPROVED] Allow no_auth_user to be an nkey. #4938

merged 1 commit into from Jan 10, 2024

Conversation

derekcollison
Copy link
Member

Partially resolves #3196

Signed-off-by: Derek Collison derek@nats.io

@derekcollison derekcollison requested a review from a team as a code owner January 10, 2024 06:16
@derekcollison
Allow no_auth_user to be an nkey.
b9ed71f 
Signed-off-by: Derek Collison <derek@nats.io>
neilalexander
neilalexander approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 34911b5 into main Jan 10, 2024
4 checks passed
@derekcollison derekcollison deleted the nkey-noauth-user branch January 10, 2024 12:37
@neilalexander neilalexander mentioned this pull request Jan 10, 2024
Merged
neilalexander added a commit that referenced this pull request Jan 10, 2024
@neilalexander
Cherry-pick PRs into v2.10.8 release branch (#4941)
ab71f02 
Cherry-pick the following PRs into the 2.10.8 release branch:

* #4937
* #4935 
* #4938 
* #4940

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilalexander neilalexander neilalexander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sample config with leafnode and nkeys
2 participants
@derekcollison @neilalexander