Improve finding the last sourced message for each source of a stream #4935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnmoyne
force-pushed
the
jnm/source_first_seq
branch
from
3d493fa
to
256dece
Compare
derekcollison
approved these changes
Jan 10, 2024
|
You have some basic go fmt issues etc you need to fix.. |
|
|
jnmoyne
force-pushed
the
jnm/source_first_seq
branch
4 times, most recently
from
90b3d1e
to
7a45f80
Compare
…one go rather than repeatedly Consolidation to avoid code duplication between setStartingSequenceForSource and setStartingSequenceForSources Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
jnmoyne
force-pushed
the
jnm/source_first_seq
branch
from
8cdeedb
to
d52ccc3
Compare
neilalexander
added a commit
that referenced
this pull request
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves how the sequence number of the last sourced message is found for all the stream's sources (in a single pass rather that individual passes for each source).
Signed-off-by: Jean-Noël Moyne jnmoyne@gmail.com