Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVED] Only call into stream update() iff the config has changed. #4898

Merged
merged 1 commit into from
Dec 19, 2023
Merged

[IMPROVED] Only call into stream update() iff the config has changed. #4898

merged 1 commit into from
Dec 19, 2023

Conversation

derekcollison
Copy link
Member

Signed-off-by: Derek Collison derek@nats.io

@derekcollison
Only call into update() iff the config has changed.
548de33 
Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison derekcollison requested a review from a team as a code owner December 19, 2023 07:24
neilalexander
neilalexander approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 6ed27fe into main Dec 19, 2023
4 checks passed
@derekcollison derekcollison deleted the no-update-needed branch December 19, 2023 13:02
@neilalexander neilalexander mentioned this pull request Dec 19, 2023
Merged
neilalexander added a commit that referenced this pull request Dec 19, 2023
@neilalexander
Cherry-pick PRs into v2.10.8 release branch (#4900)
1c9c3a6 
Cherry-picks the following PRs into the v2.10.8 release branch:

* #4894
* #4898
* #4895
* #4897
* #4896

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilalexander neilalexander neilalexander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@derekcollison @neilalexander