[IMPROVED] Do not load all blocks for NumPending when delivery is LastPerSubject. #4885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekcollison
force-pushed
the
np-lastbysubj
branch
from
b5e7eb1
to
35b80ac
Compare
|
I see that |
…ent. This was causing us to load all blocks to calulate NumPending for a new consumer with LastBySubject delivery. Note this will be drastically improved with stree(ART) in a later PR. Signed-off-by: Derek Collison <derek@nats.io>
derekcollison
force-pushed
the
np-lastbysubj
branch
from
35b80ac
to
83fb188
Compare
wallyqs
added a commit
that referenced
this pull request
Dec 15, 2023
Includes: - Check all filterSubjects of consumers when purging a stream (#4873) - Move tokenizing of subject after early returns (#4880) - Move helper subjectInfo() to the file where it's used (#4881) - JSAPI internal routing and reporting and Source and Mirror setup (#4884) - Do not load all blocks for NumPending when delivery is LastPerSubject. (#4885) - Detect corrupt psim subjects during recovery of index.db (#4890) - Add 'certs' option to TLS block for multi-certs support (#4889)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update NumPending to use PSIM since block based fss is no longer present in >= 2.10.x
This was causing us to load all blocks to calculate NumPending for a new consumer with LastBySubject delivery.
Note this will be drastically improved with the new stree(ART) data structure in a future PR.
Signed-off-by: Derek Collison <derek@nats.io