v2.9.x: Change CI and nightlies to use Go 1.20 #4487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Waldemar Quevedo <wally@nats.io>
In +Go 1.20, the x509.HostnameError changed to be wrapped in a tls.CertificateVerificationError so sometimes the name would not be reset. This would make the `TestGatewayTLSMixedIPAndDNS` test flake sometimes. Signed-off-by: Waldemar Quevedo <wally@nats.io>
.travis.yml
Outdated
| @@ -6,7 +6,9 @@ vm: | |||
|
|
|||
| language: go | |||
| go: | |||
| - "1.20.x" | |||
| - "1.19.12" | |||
There was a problem hiding this comment.
Do we want to double our builds here?
There was a problem hiding this comment.
Updated to remove v1.19 from the build
derekcollison
requested changes
Sep 4, 2023
Signed-off-by: Waldemar Quevedo <wally@nats.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes fix for test
TestGatewayTLSMixedIPAndDNSthat was breaking in Go 1.20.