Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates all gnatsd logging to use apcera/logging #4

Closed
wants to merge 5 commits into from
Closed

Conversation

cee-dub
Copy link

@cee-dub cee-dub commented Jun 11, 2013

No description provided.

@cee-dub
Copy link
Author

cee-dub commented Jun 11, 2013

Just in case, @liquidgecka or @krobertson want to take a look? I worked on this with @klobucar.

@cee-dub
Copy link
Author

cee-dub commented Jun 11, 2013

Meant to point this at @derekcollison for main review.

@derekcollison
Copy link
Member

See comments from other commits. For now will probably not pull in and undo
other commits that introduce dependencies that could limit OSS of this
component. Once all the other items are OSS, then we can re-introduce them
without effecting OSS release schedules for this component.

On Tue, Jun 11, 2013 at 3:35 PM, Cameron Walters (cee-dub) <
notifications@github.com> wrote:

Meant to point this at @derekcollison https://github.com/derekcollisonfor main review.


Reply to this email directly or view it on GitHubhttps://github.com//pull/4#issuecomment-19297045
.

@cee-dub
Copy link
Author

cee-dub commented Jun 12, 2013

This is just a branch and PR, as Jon said. I think it's safe to leave as a branch until you're comfortable with the OSS plans of all dependencies.

---Sent from Boxer | http://getboxer.com

On Tue, Jun 11, 2013 at 07:48 PM, Derek Collison wrote:See comments from other commits. For now will probably not pull in and undo other commits that introduce dependencies that could limit OSS of this component. Once all the other items are OSS, then we can re-introduce them without effecting OSS release schedules for this component. On Tue, Jun 11, 2013 at 3:35 PM, Cameron Walters (cee-dub) < notifications@github.com> wrote: > Meant to point this at @derekcollison https://github.com/derekcollisonfor main review. > > — > Reply to this email directly or view it on GitHubhttps://github.com//pull/4#issuecomment-19297045 > . > —Reply to this email directly or view it on GitHub.

@cee-dub
Copy link
Author

cee-dub commented Jun 12, 2013

I'd also appreciate if you take a closer look at the true dependencies added. As far as I can see, it just adds apcera/logging and the logging facility's unittest helper. It does not depend on testtool or other private repos.

I think we're close on open sourcing logging, and at that point this should be acceptable (barring any other potential issues).

@derekcollison
Copy link
Member

I could have missed it, so that is good that it is just one..

On Tue, Jun 11, 2013 at 11:29 PM, Cameron Walters (cee-dub) <
notifications@github.com> wrote:

I'd also appreciate if you take a closer look at the true dependencies
added. As far as I can see, it just adds apcera/logging and the logging
facility's unittest helper. It does not depend on testtool or other private
repos.

I think we're close on open sourcing logging, and at that point this
should be acceptable (barring any other potential issues).


Reply to this email directly or view it on GitHubhttps://github.com//pull/4#issuecomment-19308788
.

@liquidgecka
Copy link
Contributor

Also would love comments: https://github.com/apcera/logging/pull/12 =)

@klobucar klobucar closed this Oct 18, 2013
gaozhidf pushed a commit to ericsson-ddi/gnatsd that referenced this pull request Nov 3, 2016
levb referenced this pull request in levb/nats-server Dec 6, 2023
levb referenced this pull request in levb/nats-server Dec 6, 2023
levb referenced this pull request in levb/nats-server Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants