Set active for Sources and Mirrors to -1 on no contact #2903
+33
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the delta since now. This would wrap and create a large number which overflowed JSON's 2^53 limit. Signed-off-by: Derek Collison <derek@nats.io>
derekcollison
force-pushed
the
active_wrap
branch
from
b4a87c3 to
4b9bc29
Compare
ripienaar
approved these changes
Mar 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we had not heard from a source or mirror we would still calculated active.
This would wrap and create a large number which overflowed JSON's 2^53 limit.
This would cause schema violations in the NATS cli.
Signed-off-by: Derek Collison derek@nats.io
/cc @nats-io/core