Replace babel-eslint with @babel/eslint-parser #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
Looks like this fails the automated tests. |
Whoops! Have added a basic babel config file (which is why it was failing), copying the contents of: tesseract.js/scripts/webpack.config.common.js Lines 15 to 22 in 3c112b4 |
Fdawgs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves part of #725.
Will look at tackling the rest of the outdated/deprecated dependencies if this PR is accepted.
This also reduces production installs of this module by ~17MB by moving
@babel/eslint-parserto the dev dependencies where it belongs, as it is never used by any production functionality.