-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(napi-derive): bail the unexpected factory directive #2051
Merged
Brooooooklyn
merged 1 commit into
main
from
04-17-fix_napi_handle_panic_in_async_block_split
Apr 17, 2024
Merged
fix(napi-derive): bail the unexpected factory directive #2051
Brooooooklyn
merged 1 commit into
main
from
04-17-fix_napi_handle_panic_in_async_block_split
Apr 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sponsor
Member
Brooooooklyn
commented
Apr 17, 2024
•
edited
edited
- Close [napi] Macro compiles & expands but doesn't register exports #2048
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @Brooooooklyn and the rest of your teammates on Graphite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 67ef9c4 | Previous: 8f5d7e5 | Ratio |
---|---|---|---|
noop#napi-rs |
84279163 ops/sec (±2.37% ) |
86434309 ops/sec (±0.3% ) |
1.03 |
noop#JavaScript |
822106735 ops/sec (±0.11% ) |
819376427 ops/sec (±0.08% ) |
1.00 |
Plus number#napi-rs |
14288372 ops/sec (±0.75% ) |
20433636 ops/sec (±0.18% ) |
1.43 |
Plus number#JavaScript |
822081453 ops/sec (±0.1% ) |
816213993 ops/sec (±0.23% ) |
0.99 |
Create buffer#napi-rs |
671727 ops/sec (±12.67% ) |
656471 ops/sec (±12.99% ) |
0.98 |
Create buffer#JavaScript |
3078276 ops/sec (±6.2% ) |
3244267 ops/sec (±1.9% ) |
1.05 |
createArray#createArrayJson |
55076 ops/sec (±0.39% ) |
53116 ops/sec (±0.65% ) |
0.96 |
createArray#create array for loop |
10351 ops/sec (±0.65% ) |
10264 ops/sec (±0.38% ) |
0.99 |
createArray#create array with serde trait |
10406 ops/sec (±0.63% ) |
10360 ops/sec (±0.35% ) |
1.00 |
getArrayFromJs#get array from json string |
24139 ops/sec (±0.45% ) |
23787 ops/sec (±0.63% ) |
0.99 |
getArrayFromJs#get array from serde |
12604 ops/sec (±0.48% ) |
12610 ops/sec (±0.63% ) |
1.00 |
getArrayFromJs#get array with for loop |
15919 ops/sec (±0.49% ) |
15910 ops/sec (±0.49% ) |
1.00 |
Get Set property#Get Set from native#u32 |
560761 ops/sec (±12.96% ) |
570816 ops/sec (±13.18% ) |
1.02 |
Get Set property#Get Set from JavaScript#u32 |
548247 ops/sec (±2.42% ) |
541293 ops/sec (±2.57% ) |
0.99 |
Get Set property#Get Set from native#string |
549810 ops/sec (±11.68% ) |
558604 ops/sec (±12.05% ) |
1.02 |
Get Set property#Get Set from JavaScript#string |
516658 ops/sec (±2.2% ) |
519475 ops/sec (±1.95% ) |
1.01 |
Async task#spawn task |
26444 ops/sec (±0.78% ) |
26644 ops/sec (±0.33% ) |
1.01 |
Async task#ThreadSafeFunction |
9461 ops/sec (±0.9% ) |
8839 ops/sec (±1.02% ) |
0.93 |
Async task#Tokio future to Promise |
34388 ops/sec (±0.89% ) |
34949 ops/sec (±1.44% ) |
1.02 |
Query#query * 100 |
3635 ops/sec (±1.52% ) |
3701 ops/sec (±0.36% ) |
1.02 |
Query#query * 1 |
27264 ops/sec (±0.71% ) |
27398 ops/sec (±1.71% ) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Base automatically changed from
04-17-fix_napi_handle_panic_in_async_block
to
main
April 17, 2024 15:34
Brooooooklyn
force-pushed
the
04-17-fix_napi_handle_panic_in_async_block_split
branch
from
April 17, 2024 15:35
7ca97fd
to
67ef9c4
Compare
Merge activity
|
Brooooooklyn
deleted the
04-17-fix_napi_handle_panic_in_async_block_split
branch
April 17, 2024 16:14
Brooooooklyn
added a commit
that referenced
this pull request
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.