Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(napi-derive): bail the unexpected factory directive #2051

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

Brooooooklyn
Copy link
Sponsor Member

@Brooooooklyn Brooooooklyn commented Apr 17, 2024

Copy link
Sponsor Member Author

Brooooooklyn commented Apr 17, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Brooooooklyn and the rest of your teammates on Graphite Graphite

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 67ef9c4 Previous: 8f5d7e5 Ratio
noop#napi-rs 84279163 ops/sec (±2.37%) 86434309 ops/sec (±0.3%) 1.03
noop#JavaScript 822106735 ops/sec (±0.11%) 819376427 ops/sec (±0.08%) 1.00
Plus number#napi-rs 14288372 ops/sec (±0.75%) 20433636 ops/sec (±0.18%) 1.43
Plus number#JavaScript 822081453 ops/sec (±0.1%) 816213993 ops/sec (±0.23%) 0.99
Create buffer#napi-rs 671727 ops/sec (±12.67%) 656471 ops/sec (±12.99%) 0.98
Create buffer#JavaScript 3078276 ops/sec (±6.2%) 3244267 ops/sec (±1.9%) 1.05
createArray#createArrayJson 55076 ops/sec (±0.39%) 53116 ops/sec (±0.65%) 0.96
createArray#create array for loop 10351 ops/sec (±0.65%) 10264 ops/sec (±0.38%) 0.99
createArray#create array with serde trait 10406 ops/sec (±0.63%) 10360 ops/sec (±0.35%) 1.00
getArrayFromJs#get array from json string 24139 ops/sec (±0.45%) 23787 ops/sec (±0.63%) 0.99
getArrayFromJs#get array from serde 12604 ops/sec (±0.48%) 12610 ops/sec (±0.63%) 1.00
getArrayFromJs#get array with for loop 15919 ops/sec (±0.49%) 15910 ops/sec (±0.49%) 1.00
Get Set property#Get Set from native#u32 560761 ops/sec (±12.96%) 570816 ops/sec (±13.18%) 1.02
Get Set property#Get Set from JavaScript#u32 548247 ops/sec (±2.42%) 541293 ops/sec (±2.57%) 0.99
Get Set property#Get Set from native#string 549810 ops/sec (±11.68%) 558604 ops/sec (±12.05%) 1.02
Get Set property#Get Set from JavaScript#string 516658 ops/sec (±2.2%) 519475 ops/sec (±1.95%) 1.01
Async task#spawn task 26444 ops/sec (±0.78%) 26644 ops/sec (±0.33%) 1.01
Async task#ThreadSafeFunction 9461 ops/sec (±0.9%) 8839 ops/sec (±1.02%) 0.93
Async task#Tokio future to Promise 34388 ops/sec (±0.89%) 34949 ops/sec (±1.44%) 1.02
Query#query * 100 3635 ops/sec (±1.52%) 3701 ops/sec (±0.36%) 1.02
Query#query * 1 27264 ops/sec (±0.71%) 27398 ops/sec (±1.71%) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Base automatically changed from 04-17-fix_napi_handle_panic_in_async_block to main April 17, 2024 15:34
@Brooooooklyn Brooooooklyn force-pushed the 04-17-fix_napi_handle_panic_in_async_block_split branch from 7ca97fd to 67ef9c4 Compare April 17, 2024 15:35
Copy link
Sponsor Member Author

Brooooooklyn commented Apr 17, 2024

Merge activity

  • Apr 17, 11:35 AM EDT: Graphite rebased this pull request as part of a merge.
  • Apr 17, 11:41 AM EDT: Graphite couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Address sanitizer').
  • Apr 17, 12:14 PM EDT: @Brooooooklyn merged this pull request with Graphite.

@Brooooooklyn Brooooooklyn merged commit 22c751c into main Apr 17, 2024
51 checks passed
@Brooooooklyn Brooooooklyn deleted the 04-17-fix_napi_handle_panic_in_async_block_split branch April 17, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[napi] Macro compiles & expands but doesn't register exports
1 participant