Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Structured Output Parser Node, Auto-fixing Output Parser Node, Tools Agent Node): Structured output improvements #13908

Merged
merged 3 commits into from
Mar 13, 2025

Conversation

burivuhster
Copy link
Contributor

@burivuhster burivuhster commented Mar 13, 2025

Summary

Addressing some of the issues with structured output parsing:

  • Updated prompt for the response formatting tool
  • Fix exception handling in Auto-fixing parser, which previously prevented retries
  • Add an attempt to recover from doubly-nested output json issue

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Sorry, something went wrong.

OlegIvaniv and others added 3 commits March 10, 2025 11:54

Verified

This commit was signed with the committer’s verified signature.
… improve formatting message

Verified

This commit was signed with the committer’s verified signature.
burivuhster Eugene

Verified

This commit was signed with the committer’s verified signature.
burivuhster Eugene
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...hain/utils/output_parsers/N8nOutputFixingParser.ts 25.00% 3 Missing ⚠️
...in/nodes/agents/Agent/agents/ToolsAgent/execute.ts 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@burivuhster burivuhster requested a review from OlegIvaniv March 13, 2025 13:41
@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Mar 13, 2025
Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Mar 13, 2025

n8n    Run #9749

Run Properties:  status check passed Passed #9749  •  git commit 1e82895ad1: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 burivuhster 🗃️ e2e/*
Project n8n
Branch Review ai-623-output-parser-on-agent-is-unreliable
Run status status check passed Passed #9749
Run duration 04m 45s
Commit git commit 1e82895ad1: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 burivuhster 🗃️ e2e/*
Committer Eugene Molodkin
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 440
View all changes introduced in this branch ↗︎

@burivuhster burivuhster marked this pull request as ready for review March 13, 2025 15:19
@burivuhster burivuhster merged commit 5b6b787 into master Mar 13, 2025
35 of 37 checks passed
@burivuhster burivuhster deleted the ai-623-output-parser-on-agent-is-unreliable branch March 13, 2025 15:20
guillaumejacquart pushed a commit that referenced this pull request Mar 13, 2025

Partially verified

This commit is signed with the committer’s verified signature.
guillaumejacquart’s contribution has been verified via SSH key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
…ols Agent Node): Structured output improvements (#13908)

Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
guillaumejacquart pushed a commit that referenced this pull request Mar 13, 2025

Partially verified

This commit is signed with the committer’s verified signature.
guillaumejacquart’s contribution has been verified via SSH key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
…ols Agent Node): Structured output improvements (#13908)

Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
guillaumejacquart pushed a commit that referenced this pull request Mar 13, 2025

Partially verified

This commit is signed with the committer’s verified signature.
guillaumejacquart’s contribution has been verified via SSH key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
…ols Agent Node): Structured output improvements (#13908)

Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
guillaumejacquart pushed a commit that referenced this pull request Mar 14, 2025

Partially verified

This commit is signed with the committer’s verified signature.
guillaumejacquart’s contribution has been verified via SSH key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
…ols Agent Node): Structured output improvements (#13908)

Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
@github-actions github-actions bot mentioned this pull request Mar 17, 2025
@janober
Copy link
Member

janober commented Mar 17, 2025

Got released with n8n@1.84.0

MrJasperTan pushed a commit to MrJasperTan/n8n that referenced this pull request Mar 17, 2025

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
…ols Agent Node): Structured output improvements (n8n-io#13908)

Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants