fix(core): Clean run data for dirty nodes properly, including their children #13821
+180
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
despairblue
force-pushed
the
pay-2652-bug-partial-execution-across-merge-node-with-pinned-data
branch
from
1ad721e to
03366d9
Compare
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
despairblue
added
the
release/backport
n8n-assistant
bot
added
core
netroy
requested changes
Mar 11, 2025
despairblue
force-pushed
the
pay-2652-bug-partial-execution-across-merge-node-with-pinned-data
branch
from
d10e08b to
c6b548e
Compare
despairblue
commented
Mar 11, 2025
|
✅ All Cypress E2E specs passed |
despairblue
deleted the
pay-2652-bug-partial-execution-across-merge-node-with-pinned-data
branch
cstuncsik
pushed a commit
that referenced
this pull request
Mar 12, 2025
Merged
cstuncsik
pushed a commit
that referenced
this pull request
Mar 12, 2025
Merged
|
Got released with |
guillaumejacquart
pushed a commit
that referenced
this pull request
Mar 13, 2025
guillaumejacquart
pushed a commit
that referenced
this pull request
Mar 14, 2025
Merged
MrJasperTan
pushed a commit
to MrJasperTan/n8n
that referenced
this pull request
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This cleans run data of dirty nodes properly, including cleaning the run data of their children.
If this is not done we miscalculate the start nodes in situations involving nodes with multiple inputs and the graph branching and joining again, this leads to the
waitingExecutionbeing setup incorrectly and the execution terminating too early.before:
PAY-2652-before.mp4
after:
PAY-2652-after.mp4
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/PAY-2652/bug-partial-execution-across-merge-node-with-pinned-data
Review / Merge checklist
Docs updated or follow-up ticket created.release/backport(if the PR is an urgent fix that needs to be backported)