Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Hints for tools and agent #13386

Merged
merged 9 commits into from
Mar 12, 2025
Merged

Conversation

michael-radency
Copy link
Contributor

@michael-radency michael-radency commented Feb 20, 2025

Summary

when a node-as-tool is called and there are no placeholders to be filled by AI:
No parameters are set up to be filled by AI. Click on the ✨ button next to a parameter to allow AI to set its value.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-2088/add-warnings-for-tools

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Sorry, something went wrong.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
…add-warnings-for-tools
@michael-radency michael-radency added ui Enhancement in /editor-ui or /design-system n8n team Authored by the n8n team labels Feb 20, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…add-warnings-for-tools

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@dana-gill dana-gill requested a review from ShireenMissi March 6, 2025 08:08
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…add-warnings-for-tools

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…add-warnings-for-tools

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
…add-warnings-for-tools
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Mar 12, 2025

n8n    Run #9732

Run Properties:  status check passed Passed #9732  •  git commit ec8a719efa: 🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Project n8n
Branch Review master
Run status status check passed Passed #9732
Run duration 04m 48s
Commit git commit ec8a719efa: 🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Committer Michael Kret
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 6
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 454
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@ShireenMissi ShireenMissi merged commit ec8a719 into master Mar 12, 2025
37 checks passed
@ShireenMissi ShireenMissi deleted the node-2088-add-warnings-for-tools branch March 12, 2025 17:08
RicardoE105 pushed a commit that referenced this pull request Mar 13, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
guillaumejacquart pushed a commit that referenced this pull request Mar 13, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
guillaumejacquart pushed a commit that referenced this pull request Mar 14, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@github-actions github-actions bot mentioned this pull request Mar 17, 2025
@janober
Copy link
Member

janober commented Mar 17, 2025

Got released with n8n@1.84.0

MrJasperTan pushed a commit to MrJasperTan/n8n that referenced this pull request Mar 17, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants