fix(core): Find correct start nodes when the first node after that has no run data has pinned data (#13784)

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com>

Author: despairblue

packages/core/src/execution-engine/partial-execution-utils/__tests__/find-start-nodes.test.ts

@@ -443,7 +443,49 @@ describe('findStartNodes', () => {
 		expect(startNodes).toContainEqual(node2);
 	});
 
+	describe('pinData', () => {
+		//               PD              ►►
+		// ┌───────┐1   ┌──────────┐0   ┌───────────┐
+		// │trigger├────►pinnedNode├────►destination│
+		// └───────┘    └──────────┘    └───────────┘
+		test('does not stop recursing when the first node that has no run data has pinned data', () => {
+			// ARRANGE
+			const trigger = createNodeData({ name: 'trigger' });
+			const pinnedNode = createNodeData({ name: 'pinnedNode' });
+			const destination = createNodeData({ name: 'destinationNode' });
+			const graph = new DirectedGraph()
+				.addNodes(trigger, destination, pinnedNode)
+				.addConnections({ from: trigger, to: pinnedNode }, { from: pinnedNode, to: destination });
+			const pinData: IPinData = { [pinnedNode.name]: [{ json: { value: 1 } }] };
+			const runData: IRunData = {
+				[trigger.name]: [toITaskData([{ data: { value: 1 } }])],
+			};
+
+			// ACT
+			const startNodes = findStartNodes({
+				graph,
+				trigger,
+				destination,
+				runData,
+				pinData,
+			});
+
+			// ASSERT
+			expect(startNodes.size).toBe(1);
+			expect(startNodes).toContain(destination);
+		});
+	});
+
 	describe('custom loop logic', () => {
+		//                       ►►
+		//             ┌────┐0  ┌─────────┐
+		// ┌───────┐1  │    ├───►afterLoop│
+		// │trigger├─┬─►loop│1  └─────────┘
+		// └───────┘ │ │    ├─┐ ┌──────┐1
+		//           │ └────┘ └─►inLoop├──┐
+		//           │          └──────┘  │
+		//           └────────────────────┘
+		//
 		test('if the last run of loop node has no data (null) on the done output, then the loop is the start node', () => {
 			// ARRANGE
 			const trigger = createNodeData({ name: 'trigger' });
@@ -482,6 +524,15 @@ describe('findStartNodes', () => {
 			expect(startNodes).toContainEqual(loop);
 		});
 
+		//                       ►►
+		//             ┌────┐0  ┌─────────┐
+		// ┌───────┐1  │    ├───►afterLoop│
+		// │trigger├─┬─►loop│1  └─────────┘
+		// └───────┘ │ │    ├─┐ ┌──────┐1
+		//           │ └────┘ └─►inLoop├──┐
+		//           │          └──────┘  │
+		//           └────────────────────┘
+		//
 		test('if the last run of loop node has no data (empty array) on the done output, then the loop is the start  node', () => {
 			// ARRANGE
 			const trigger = createNodeData({ name: 'trigger' });
@@ -527,6 +578,15 @@ describe('findStartNodes', () => {
 			expect(startNodes).toContainEqual(loop);
 		});
 
+		//                       ►►
+		//             ┌────┐1  ┌─────────┐
+		// ┌───────┐1  │    ├───►afterLoop│
+		// │trigger├─┬─►loop│1  └─────────┘
+		// └───────┘ │ │    ├─┐ ┌──────┐1
+		//           │ └────┘ └─►inLoop├──┐
+		//           │          └──────┘  │
+		//           └────────────────────┘
+		//
 		test('if the loop has data on the done output in the last run it does not become a start node', () => {
 			// ARRANGE
 			const trigger = createNodeData({ name: 'trigger' });

packages/core/src/execution-engine/partial-execution-utils/find-start-nodes.ts

@@ -111,7 +111,8 @@ function findStartNodesRecursive(
 		// If the node has multiple outputs, only follow the outputs that have run data.
 		const hasNoRunData =
 			nodeRunData === null || nodeRunData === undefined || nodeRunData.data.length === 0;
-		if (hasNoRunData) {
+		const hasNoPinnedData = pinData[outGoingConnection.from.name] === undefined;
+		if (hasNoRunData && hasNoPinnedData) {
 			continue;
 		}