refactor(iroh): magical pin projections #3060
Merged
+28
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
force-pushed
the
refactor-project-pins
branch
from
10bd61e to
458740c
Compare
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3060/docs/iroh/ Last updated: 2024-12-18T14:44:52Z |
flub
approved these changes
Dec 18, 2024
iroh/src/magicsock/relay_actor.rs
Outdated
| @@ -182,7 +182,7 @@ impl ActiveRelayActor { | |||
| // When this future has an inner, it is a future which is currently sending | |||
| // something to the relay server. Nothing else can be sent to the relay server at | |||
| // the same time. | |||
| let mut relay_send_fut = MaybeFuture::none(); | |||
| let mut relay_send_fut = std::pin::pin!(MaybeFuture::default()); | |||
There was a problem hiding this comment.
FWIW I do prefer the ::none() constructor over ::default(). It feels more coherent with .set_none(), .is_none() etc. But I can live with ::default() if you strongly prefer it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoids the
Box::pininside of the loopBreaking Changes
Notes & open questions
Change checklist