Skip to content

Commit b6cb9a0

Browse files
committedNov 24, 2019
💥 update no-unsupported-features/node-builtins rule based on Node 13.2
1 parent 0b0c2aa commit b6cb9a0

File tree

3 files changed

+51
-23
lines changed

3 files changed

+51
-23
lines changed
 

‎docs/rules/no-unsupported-features/node-builtins.md

+13-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Editor integrations of ESLint would be useful to know it in real-time.
1010

1111
## 📖 Rule Details
1212

13-
This rule reports APIs of Node.js built-in APIs on the basis of [Node.js v12.0.0 Documentation](https://nodejs.org/docs/v12.0.0/api/).
13+
This rule reports APIs of Node.js built-in APIs on the basis of [Node.js v13.2.0 Documentation](https://nodejs.org/docs/v13.2.0/api/).
1414

1515
### Configured Node.js version range
1616

@@ -201,6 +201,8 @@ The `"ignores"` option accepts an array of the following strings.
201201
- `"fs.realpath.native"`
202202
- `"fs.realpathSync.native"`
203203
- `"fs.promises"`
204+
- `"fs.writev"`
205+
- `"fs.writevSync"`
204206

205207
**`http2` module:**
206208

@@ -212,7 +214,14 @@ The `"ignores"` option accepts an array of the following strings.
212214

213215
**`module` module:**
214216

217+
- `"module.Module.builtinModules"`
218+
- `"module.Module.createRequireFromPath"`
219+
- `"module.Module.createRequire"`
220+
- `"module.Module.syncBuiltinESMExports"`
215221
- `"module.builtinModules"`
222+
- `"module.createRequireFromPath"`
223+
- `"module.createRequire"`
224+
- `"module.syncBuiltinESMExports"`
216225

217226
**`os` module:**
218227

@@ -246,6 +255,7 @@ The `"ignores"` option accepts an array of the following strings.
246255
- `"process.ppid"`
247256
- `"process.release"`
248257
- `"process.report"`
258+
- `"process.resourceUsage"`
249259
- `"process.setegid"`
250260
- `"process.seteuid"`
251261
- `"process.setUncaughtExceptionCaptureCallback"`
@@ -256,6 +266,7 @@ The `"ignores"` option accepts an array of the following strings.
256266

257267
**`stream` module:**
258268

269+
- `"stream.Readable.from"`
259270
- `"stream.finished"`
260271
- `"stream.pipeline"`
261272

@@ -294,6 +305,7 @@ The `"ignores"` option accepts an array of the following strings.
294305
- `"v8.Serializer"`
295306
- `"v8.cachedDataVersionTag"`
296307
- `"v8.deserialize"`
308+
- `"v8.getHeapCodeStatistics"`
297309
- `"v8.getHeapSnapshot"`
298310
- `"v8.getHeapSpaceStatistics"`
299311
- `"v8.serialize"`

‎lib/rules/no-unsupported-features/node-builtins.js

+19-3
Original file line numberDiff line numberDiff line change
@@ -123,15 +123,26 @@ const trackMap = {
123123
promises: {
124124
[READ]: { supported: "11.14.0", experimental: "10.1.0" },
125125
},
126+
writev: { [READ]: { supported: "12.9.0" } },
127+
writevSync: { [READ]: { supported: "12.9.0" } },
126128
},
127129
http2: {
128-
[READ]: { supported: "8.4.0" },
130+
[READ]: { supported: "10.10.0", experimental: "8.4.0" },
129131
},
130132
inspector: {
131-
[READ]: { supported: "8.0.0" },
133+
[READ]: { supported: null, experimental: "8.0.0" },
132134
},
133135
module: {
136+
Module: {
137+
builtinModules: { [READ]: { supported: "9.3.0" } },
138+
createRequireFromPath: { [READ]: { supported: "10.12.0" } },
139+
createRequire: { [READ]: { supported: "12.2.0" } },
140+
syncBuiltinESMExports: { [READ]: { supported: "12.12.0" } },
141+
},
134142
builtinModules: { [READ]: { supported: "9.3.0" } },
143+
createRequireFromPath: { [READ]: { supported: "10.12.0" } },
144+
createRequire: { [READ]: { supported: "12.2.0" } },
145+
syncBuiltinESMExports: { [READ]: { supported: "12.12.0" } },
135146
},
136147
os: {
137148
constants: {
@@ -167,6 +178,7 @@ const trackMap = {
167178
ppid: { [READ]: { supported: "9.2.0" } },
168179
release: { [READ]: { supported: "3.0.0" } },
169180
report: { [READ]: { supported: null, experimental: "11.8.0" } },
181+
resourceUsage: { [READ]: { supported: "12.6.0" } },
170182
setegid: { [READ]: { supported: "2.0.0" } },
171183
seteuid: { [READ]: { supported: "2.0.0" } },
172184
setUncaughtExceptionCaptureCallback: {
@@ -182,6 +194,9 @@ const trackMap = {
182194
},
183195
},
184196
stream: {
197+
Readable: {
198+
from: { [READ]: { supported: "12.3.0" } },
199+
},
185200
finished: { [READ]: { supported: "10.0.0" } },
186201
pipeline: { [READ]: { supported: "10.0.0" } },
187202
},
@@ -220,6 +235,7 @@ const trackMap = {
220235
Serializer: { [READ]: { supported: "8.0.0" } },
221236
cachedDataVersionTag: { [READ]: { supported: "8.0.0" } },
222237
deserialize: { [READ]: { supported: "8.0.0" } },
238+
getHeapCodeStatistics: { [READ]: { supported: "12.8.0" } },
223239
getHeapSnapshot: { [READ]: { supported: "11.13.0" } },
224240
getHeapSpaceStatistics: { [READ]: { supported: "6.0.0" } },
225241
serialize: { [READ]: { supported: "8.0.0" } },
@@ -230,7 +246,7 @@ const trackMap = {
230246
compileFunction: { [READ]: { supported: "10.10.0" } },
231247
},
232248
worker_threads: {
233-
[READ]: { supported: null, experimental: "10.5.0" },
249+
[READ]: { supported: "12.11.0", experimental: "10.5.0" },
234250
},
235251
},
236252
}

‎tests/lib/rules/no-unsupported-features/node-builtins.js

+19-19
Original file line numberDiff line numberDiff line change
@@ -2576,11 +2576,11 @@ new RuleTester({
25762576
valid: [
25772577
{
25782578
code: "require('http2')",
2579-
options: [{ version: "8.4.0" }],
2579+
options: [{ version: "10.10.0" }],
25802580
},
25812581
{
25822582
code: "import http2 from 'http2'",
2583-
options: [{ version: "8.4.0" }],
2583+
options: [{ version: "10.10.0" }],
25842584
},
25852585
{
25862586
code: "require('http2')",
@@ -2600,7 +2600,7 @@ new RuleTester({
26002600
messageId: "unsupported",
26012601
data: {
26022602
name: "http2",
2603-
supported: "8.4.0",
2603+
supported: "10.10.0",
26042604
version: "8.3.9",
26052605
},
26062606
},
@@ -2614,7 +2614,7 @@ new RuleTester({
26142614
messageId: "unsupported",
26152615
data: {
26162616
name: "http2",
2617-
supported: "8.4.0",
2617+
supported: "10.10.0",
26182618
version: "8.3.9",
26192619
},
26202620
},
@@ -2628,7 +2628,7 @@ new RuleTester({
26282628
messageId: "unsupported",
26292629
data: {
26302630
name: "http2",
2631-
supported: "8.4.0",
2631+
supported: "10.10.0",
26322632
version: "8.3.9",
26332633
},
26342634
},
@@ -2642,14 +2642,6 @@ new RuleTester({
26422642
//----------------------------------------------------------------------
26432643
{
26442644
valid: [
2645-
{
2646-
code: "require('inspector')",
2647-
options: [{ version: "8.0.0" }],
2648-
},
2649-
{
2650-
code: "import inspector from 'inspector'",
2651-
options: [{ version: "8.0.0" }],
2652-
},
26532645
{
26542646
code: "require('inspector')",
26552647
options: [{ version: "7.9.9", ignores: ["inspector"] }],
@@ -2668,7 +2660,7 @@ new RuleTester({
26682660
messageId: "unsupported",
26692661
data: {
26702662
name: "inspector",
2671-
supported: "8.0.0",
2663+
supported: "???",
26722664
version: "7.9.9",
26732665
},
26742666
},
@@ -2682,7 +2674,7 @@ new RuleTester({
26822674
messageId: "unsupported",
26832675
data: {
26842676
name: "inspector",
2685-
supported: "8.0.0",
2677+
supported: "???",
26862678
version: "7.9.9",
26872679
},
26882680
},
@@ -2696,7 +2688,7 @@ new RuleTester({
26962688
messageId: "unsupported",
26972689
data: {
26982690
name: "inspector",
2699-
supported: "8.0.0",
2691+
supported: "???",
27002692
version: "7.9.9",
27012693
},
27022694
},
@@ -4914,6 +4906,14 @@ new RuleTester({
49144906
{ version: "10.4.99", ignores: ["worker_threads"] },
49154907
],
49164908
},
4909+
{
4910+
code: "require('worker_threads')",
4911+
options: [{ version: "12.11.0" }],
4912+
},
4913+
{
4914+
code: "import worker_threads from 'worker_threads'",
4915+
options: [{ version: "12.11.0" }],
4916+
},
49174917
],
49184918
invalid: [
49194919
{
@@ -4924,7 +4924,7 @@ new RuleTester({
49244924
messageId: "unsupported",
49254925
data: {
49264926
name: "worker_threads",
4927-
supported: "???",
4927+
supported: "12.11.0",
49284928
version: "10.5.0",
49294929
},
49304930
},
@@ -4938,7 +4938,7 @@ new RuleTester({
49384938
messageId: "unsupported",
49394939
data: {
49404940
name: "worker_threads",
4941-
supported: "???",
4941+
supported: "12.11.0",
49424942
version: "10.5.0",
49434943
},
49444944
},
@@ -4952,7 +4952,7 @@ new RuleTester({
49524952
messageId: "unsupported",
49534953
data: {
49544954
name: "worker_threads",
4955-
supported: "???",
4955+
supported: "12.11.0",
49564956
version: "10.5.0",
49574957
},
49584958
},

0 commit comments

Comments
 (0)
Please sign in to comment.